Skip to content

Auth cache key fix #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2025
Merged

Auth cache key fix #5949

merged 2 commits into from
Jan 14, 2025

Conversation

@nischitpra
Copy link
Contributor

@nischitpra nischitpra commented Jan 14, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR introduces a new utility function for hashing keys using the crypto module, enhancing security in the authorization process. It modifies the cache key generation to use this new hashing function, ensuring a more secure and consistent way to create cache keys.

Detailed summary

  • Added a new function hashKey in utils.ts that hashes a string using SHA-256.
  • Updated the cache key generation in the authorize function to use hashKey, incorporating secretKeyHash, hashedJWT, and clientId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@nischitpra nischitpra requested a review from arcoraven January 14, 2025 10:32
@nischitpra nischitpra requested a review from a team as a code owner January 14, 2025 10:32
@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 756b0b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 11:35am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 11:35am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 11:35am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 11:35am

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

graphite-app[bot]
graphite-app bot reviewed Jan 14, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.85%. Comparing base (815f47c) to head (756b0b6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5949   +/-   ##
=======================================
  Coverage   54.85%   54.85%           
=======================================
  Files        1142     1142           
  Lines       60928    60928           
  Branches     5140     5140           
=======================================
  Hits        33424    33424           
  Misses      26777    26777           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 556d1f3
packages 52.50% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.65 KB (0%) 913 ms (0%) 962 ms (+24.78% 🔺) 1.9 s
thirdweb (cjs) 115.43 KB (0%) 2.4 s (0%) 2.3 s (+16.25% 🔺) 4.6 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 161 ms (+138.69% 🔺) 273 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 39 ms (+65.33% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.21 KB (0%) 385 ms (0%) 196 ms (+15.93% 🔺) 581 ms

@arcoraven arcoraven merged commit 23d8001 into main Jan 14, 2025
31 checks passed
@arcoraven arcoraven deleted the np/cache_key_fix branch January 14, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

+1 more reviewer

@arcoraven arcoraven arcoraven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nischitpra nischitpra

Labels

packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nischitpra @arcoraven